-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic notebook for gptassistant #636
Conversation
instructions and overwrite_instructions flag - Ensure that `system_message` is always consistent with `instructions` - Ensure provided instructions are always used - Add option to permanently modify the instructions of the assistant
- also improve logging in gpt assistant
Codecov Report
@@ Coverage Diff @@
## main #636 +/- ##
==========================================
+ Coverage 28.75% 37.11% +8.35%
==========================================
Files 27 27
Lines 3377 3379 +2
Branches 760 760
==========================================
+ Hits 971 1254 +283
+ Misses 2335 2009 -326
- Partials 71 116 +45
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
Add a link in our website. Can be done in a separate PR. |
* Refactor GPTAssistantAgent constructor to handle instructions and overwrite_instructions flag - Ensure that `system_message` is always consistent with `instructions` - Ensure provided instructions are always used - Add option to permanently modify the instructions of the assistant * Improve default behavior * Add a test; add method to delete assistant * Add a new test for overwriting instructions * Add test case for when no instructions are given for existing assistant * Add pytest markers to test_gpt_assistant.py * add test in workflow * update * fix test_client_stream * comment out test_hierarchy_ * Add basic gptassistant notebook - also improve logging in gpt assistant * Update notebook/agentchat_oai_assistant_twoagents_basic.ipynb Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu> --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com> Co-authored-by: kevin666aa <yrwu000627@gmail.com> Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
Why are these changes needed?
Related issue number
Checks