Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic notebook for gptassistant #636

Merged
merged 15 commits into from
Nov 12, 2023
Merged

Add basic notebook for gptassistant #636

merged 15 commits into from
Nov 12, 2023

Conversation

gagb
Copy link
Collaborator

@gagb gagb commented Nov 12, 2023

Why are these changes needed?

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2023

Codecov Report

Merging #636 (cbd4580) into main (c22a322) will increase coverage by 8.35%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   28.75%   37.11%   +8.35%     
==========================================
  Files          27       27              
  Lines        3377     3379       +2     
  Branches      760      760              
==========================================
+ Hits          971     1254     +283     
+ Misses       2335     2009     -326     
- Partials       71      116      +45     
Flag Coverage Δ
unittests 37.05% <0.00%> (+8.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
autogen/agentchat/contrib/gpt_assistant_agent.py 1.29% <0.00%> (+1.29%) ⬆️

... and 10 files with indirect coverage changes

Copy link
Collaborator

@IANTHEREAL IANTHEREAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@LeoLjl LeoLjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
@sonichi
Copy link
Contributor

sonichi commented Nov 12, 2023

Add a link in our website. Can be done in a separate PR.

@sonichi sonichi added this pull request to the merge queue Nov 12, 2023
@sonichi sonichi removed this pull request from the merge queue due to a manual request Nov 12, 2023
@sonichi sonichi added this pull request to the merge queue Nov 12, 2023
Merged via the queue into main with commit 032c05e Nov 12, 2023
52 of 58 checks passed
@sonichi sonichi deleted the gagb/gptassistant branch November 12, 2023 17:31
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Refactor GPTAssistantAgent constructor to handle
instructions and overwrite_instructions flag

- Ensure that `system_message` is always consistent with `instructions`
- Ensure provided instructions are always used
- Add option to permanently modify the instructions of the assistant

* Improve default behavior

* Add a test; add method to delete assistant

* Add a new test for overwriting instructions

* Add test case for when no instructions are given for existing assistant

* Add pytest markers to test_gpt_assistant.py

* add test in workflow

* update

* fix test_client_stream

* comment out test_hierarchy_

* Add basic gptassistant notebook

- also improve logging in gpt assistant

* Update notebook/agentchat_oai_assistant_twoagents_basic.ipynb

Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Co-authored-by: kevin666aa <yrwu000627@gmail.com>
Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants